GC0308: add explicit constructor to enable custom camera configs#69
Open
mhaberler wants to merge 1 commit intom5stack:mainfrom
Open
GC0308: add explicit constructor to enable custom camera configs#69mhaberler wants to merge 1 commit intom5stack:mainfrom
mhaberler wants to merge 1 commit intom5stack:mainfrom
Conversation
the way this was coded made the camera_config_t* config; member variable useless, as it is never set or used. with this change: - the constructor can optionally accept a pointer to a custom camera_config_t struct - when using the default camera_config, it can be accessed and changed via the config member variable or by passing a custom config via begin - the used config struct can always be accessed via the config member.
Author
|
ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the way this was coded made the camera_config_t* config; member variable useless, as it is never set or used.
with this change:
Here is a demo for the CoreS3 which reads and decodes a QRcode via the builtin camera, and connects to WiFi if the qrcode was a Wifi URI:
https://github.com/mhaberler/cores3-read-qrcode.git
this uses the patch attached to customize the camera config (resolution, grayscale):