Update criteria.py#42
Merged
brysontyrrell merged 2 commits intomacadmins:mainfrom Jun 4, 2024
macnotes:macnotes-add_missing_criteria_operator
Merged
Update criteria.py#42brysontyrrell merged 2 commits intomacadmins:mainfrom macnotes:macnotes-add_missing_criteria_operator
brysontyrrell merged 2 commits intomacadmins:mainfrom
macnotes:macnotes-add_missing_criteria_operator
Conversation
Add additional missing criteria from another branch
liquidz00
pushed a commit
to liquidz00/jamf-pro-sdk-python
that referenced
this pull request
Nov 23, 2025
…iteria_operator Update criteria.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was pulling smart groups and got a Pydantic validation error on a smart group that had a "more than" comparison operator on a numeric (drive full percentage, in my case). Should we add that operator? It seemed to resolve the issue without making any other changes.
Also, thanks for this SDK. I'm still having lots of "Ooh... I see what you did there..." moments.