refactor: defer resolution of markdown-it #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) So markdown-it can be lazy-loaded 2) So we can put the <script> tag of markdown-it somewhere after angular-markdown-it Signed-off-by: kfei <kfei@kfei.net>
Current coverage is 92.86%@@ master #1 diff @@
========================================
Files 1 1
Lines 24 28 +4
Methods 0 0
Branches 0 0
========================================
+ Hits 24 26 +2
- Misses 0 2 +2
Partials 0 0
|
Owner
|
@kfei Sorry for the late reply, I really like the idea 👍 |
Owner
|
It took me a while, but yeah, lets do this 😄 |
Contributor
Author
|
@macedigital Thanks for your time 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this repo. 😄
I'd like to suggest a small patch to defer the resolution of
markdown-itso that:<script>tag of markdown-it somewhere afterangular-markdown-it
Signed-off-by: kfei kfei@kfei.net