Prevent buffer overflow, fixes #17#18
Merged
mach-kernel merged 2 commits intomach-kernel:masterfrom Apr 1, 2018
Merged
Conversation
Use calloc/free instead of strdup.
A string literal is an array, which already has an address.
Contributor
Author
|
I can add a VS solution and project to this (or another) commit if you like, and a .gitignore file - just to be safe. |
Owner
|
Looks good! I would prefer to keep VS solution stuff out of the project, though. Merging this as-is and will package a new release at some point today/tomorrow. |
sicklittlemonkey
added a commit
to sicklittlemonkey/cadius
that referenced
this pull request
Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use calloc/free instead of strdup.