Fix memory corruption bug.#26
Merged
mach-kernel merged 1 commit intomach-kernel:masterfrom Nov 18, 2019
Merged
Conversation
The posix os_GetFolderFiles had a memory corruption bug where it was writing past the end of a heap-allocated array.
Owner
|
Hi, I'll try to merge this + do a pass of Thanks much! |
|
This bug was silently breaking my Total Replay builds. I ended up with the same fix. It would be great to have this PR merged. |
Owner
|
Sincere apologies for the delay, free time has been extremely scarce on my end. I have a lot of things to push through for Thanks much for following up!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The posix os_GetFolderFiles had a memory corruption bug where it
was writing past the end of a heap-allocated array.
(By the way, the same function has memory leaks; none of the memory that is allocated for paths is free'd.)