ADDFILE should never make first block sparse#43
Merged
mach-kernel merged 2 commits intomach-kernel:masterfrom Apr 7, 2025
Merged
ADDFILE should never make first block sparse#43mach-kernel merged 2 commits intomach-kernel:masterfrom
mach-kernel merged 2 commits intomach-kernel:masterfrom
Conversation
When checking if a file block can be sparse (i.e. not actually allocated on disk), ensure the test always fails for the first block of the file, as this would violate the ProDOS file system specification, and makes ProDOS-8 unhappy. Additionally, when loading a volume, log if files are encountered that have sparse first blocks. mach-kernel#42
mach-kernel
approved these changes
Jul 24, 2024
Owner
mach-kernel
left a comment
mach-kernel
left a comment
There was a problem hiding this comment.
Pardon the delay, thank you! I will cut a new tag and upload bins when I get a spare moment or two 😸
Contributor
Author
|
Quick ping on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking if a file block can be sparse (i.e. not actually allocated on disk), ensure the test always fails for the first block of the file, as this would violate the ProDOS file system specification, and makes ProDOS-8 unhappy.
Additionally, when loading a volume, log if files are encountered that have sparse first blocks.
#42