Update breaks MacVim for High Sierra

[d-tork]

Describe the bug
MacVim no longer can open new windows or existing files.

To Reproduce
Detailed steps to reproduce the behavior:

1. Updated to latest version
2. Cmd+N : nothing happens
3. Cmd+O, choose a file, nothing happens

Expected behavior
MacVim window opens.

Environment (please complete the following information):

• Vim version 8.2
• OS: macOS 10.13.6
• Terminal: GUI? I don't know, I'm just using the MacVim window.

Additional context
I went back to snapshot 166 to get a working copy. Snapshot 168 definitely not compatible with my High Sierra environment.

[mikaraunio]

Snapshot 168 doesn't work for me either on 10.13.6. Launching from the command-line gives the following:

$ /Applications/MacVim.app/Contents/MacOS/Vim
dyld: lazy symbol binding failed: Symbol not found: ____chkstk_darwin
  Referenced from: /Applications/MacVim.app/Contents/MacOS/Vim
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: ____chkstk_darwin
  Referenced from: /Applications/MacVim.app/Contents/MacOS/Vim
  Expected in: /usr/lib/libSystem.B.dylib

Abort trap: 6

[ychin]

That's unfortunate. Looking into it. It's unfortunate because we turned off older macOS version's CI due to Travis CI changing their support for OSS projects, but I will see if there is a way for me to repro this.

[Carreau]

Same for Sierra – Not sure if that helps or not, I'll revert to an older version for now.

[ketch]

Rolling back to snapshot 166 made Macvim work again for me.

[ketch]

It might be best to warn people before updating that new versions of Macvim don't support High Sierra or older versions of Mac OS.

[0xfadeef]

Same problem on El Capitan (10.11). Not reproducible with Snapshot 166.

[samantafluture]

Same problem on Sierra (10.12).

dyld: lazy symbol binding failed: Symbol not found: ____chkstk_darwin Referenced from: /Applications/MacVim.app/Contents/MacOS/Vim Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: ____chkstk_darwin Referenced from: /Applications/MacVim.app/Contents/MacOS/Vim Expected in: /usr/lib/libSystem.B.dylib

[ychin]

Ok I think I found the issue. Could be a little annoying to fix but it has to do with how gettext (library for localization) is built against newer versions of macOS.

I will push out a fix later, but for now I fixed the auto-updater (efb196d) to know not to deploy this version for macOS 10.13. If you have r166 running on macOS 10.13 (or below) and check for updates it will just say it's the latest version now, so next time the updater says there is a new build it should contain the fix.

If you have r168, you will probably need to manually download 166 from https://github.com/macvim-dev/macvim/releases.

[ychin]

This should be fixed under r169: https://github.com/macvim-dev/macvim/releases/tag/snapshot-169

Please try it and let me know if it doesn't work. If you reverted to 166 before, the auto-updater should be able to upgrade to 169 directly.