-
-
Notifications
You must be signed in to change notification settings - Fork 686
Update Sparkle to 1.24.0 #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sparkle to 1.24.0 #1118
Conversation
2fa9be9 to
50fe613
Compare
Compatible with Apple M1 (arm64)
50fe613 to
51cb5c6
Compare
|
Sorry for the delay. I'll try to merge this by end of week. There are a lot of files so just want to confirm on my end this is the same as the recent release. |
|
Is there any way to tweak this to support |
|
@ichizok I can confirm this makes MacVim master compile and run for arm64 on M1 MacBook Air with macOS 11.1 Beta. |
|
Ok merged. Sorry for the delay. But yes this should fix Apple Silicon building. The previous released Sparkle binary was not a universal binary, so when MacVim tries to build against it in a universal binary, it couldn't as there was not arm64 binary in Sparkle. The new version now supports that. |
|
But, I still build failed macOS Catalina with Xcode 12.2. |
|
I still need the patch to build macvim under homebrew. Weird. |
|
Hello, Thank you. |
|
@netcaf No there is no native Apple Silicon / M1 build yet, but you can use the current release under Rosetta. Is there a reason why you need a native Apple Silicon build? From what I have tried, Rosetta performance is decent enough that it should not make too big an impact. Apple Silicon build will come out probably after the upcoming release, so probably release 168. If you use the binary release published in https://github.com/macvim-dev/macvim/releases the automatic updater will still work and upgrade you to Apple Silicon native builds in the future. It's currently a little tricky to push out Apple Silicon builds due to lack of CI support hence the delay. |
|
I think the biggest issue is that if you’re using other arm64 binaries then macvim won’t pick those up. This means I need two versions of python3 installed, one for `vim` and one for MacVim.
~ Michael D. Stemle, Jr.
… On Dec 4, 2020, at 19:40, Yee Cheng Chin ***@***.***> wrote:
@netcaf No there is no native Apple Silicon / M1 build yet, but you can use the current release under Rosetta. Is there a reason why you need a native Apple Silicon build? From what I have tried, Rosetta performance is decent enough that it should not make too big an impact.
Apple Silicon build will come out probably after the upcoming release. If you use the binary release published in https://github.com/macvim-dev/macvim/releases the automatic updater will still work and upgrade you to Apple Silicon native builds in the future.
It's currently a little tricky to push out Apple Silicon builds due to lack of CI support hence the delay.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Yes that is correct. It does depend on where you get your Python from. For example the default Homebrew installation is still Rosetta based so if you are using that you would actually be getting the x86 version. |
@ychin Thank you for the explanation. I have just got my MacBook m1 and is full of curiosity about the new experience. Macvim is my favorite app but it’s Ok I will try it with Rosetta. Thank you all for your time. |
#1113 Sparkle 1.24.0 is compatible with Apple M1 (arm64).