Skip to content

Conversation

@ichizok
Copy link
Member

@ichizok ichizok commented Nov 15, 2020

#1113 Sparkle 1.24.0 is compatible with Apple M1 (arm64).

Compatible with Apple M1 (arm64)
@ychin
Copy link
Member

ychin commented Nov 19, 2020

Sorry for the delay. I'll try to merge this by end of week. There are a lot of files so just want to confirm on my end this is the same as the recent release.

@manchicken
Copy link

Is there any way to tweak this to support arm64 as well? I've never done much with Sparkle, but it seems like this is going to be one of many impediments to supporting the new Apple chipsets.

@felixbuenemann
Copy link
Contributor

felixbuenemann commented Nov 21, 2020

@ichizok I can confirm this makes MacVim master compile and run for arm64 on M1 MacBook Air with macOS 11.1 Beta.

@ychin ychin merged commit af031d8 into macvim-dev:master Nov 23, 2020
@ychin
Copy link
Member

ychin commented Nov 23, 2020

Ok merged. Sorry for the delay. But yes this should fix Apple Silicon building. The previous released Sparkle binary was not a universal binary, so when MacVim tries to build against it in a universal binary, it couldn't as there was not arm64 binary in Sparkle. The new version now supports that.

@ychin ychin added this to the snapshot-167 milestone Nov 23, 2020
@ichizok ichizok deleted the update-sparkle branch November 23, 2020 15:06
@markwu
Copy link

markwu commented Nov 30, 2020

But, I still build failed macOS Catalina with Xcode 12.2.

@markwu
Copy link

markwu commented Nov 30, 2020

I still need the patch to build macvim under homebrew. Weird.

@ychin
Copy link
Member

ychin commented Dec 1, 2020

Yeah Homebrew is a different issue that has to do with the way the formula works (Homebrew team seems to have been quite against the idea of building universal builds in Homebrew). This is more for fixing #1113 than #1115. I still need to resolve #1115.

@netcaf
Copy link

netcaf commented Dec 5, 2020

Hello,
Is there any native build for downloading? I tried it with homebrew but it prompted I should install Xcode.

Thank you.

@ychin
Copy link
Member

ychin commented Dec 5, 2020

@netcaf No there is no native Apple Silicon / M1 build yet, but you can use the current release under Rosetta. Is there a reason why you need a native Apple Silicon build? From what I have tried, Rosetta performance is decent enough that it should not make too big an impact.

Apple Silicon build will come out probably after the upcoming release, so probably release 168. If you use the binary release published in https://github.com/macvim-dev/macvim/releases the automatic updater will still work and upgrade you to Apple Silicon native builds in the future.

It's currently a little tricky to push out Apple Silicon builds due to lack of CI support hence the delay.

@manchicken
Copy link

manchicken commented Dec 5, 2020 via email

@ychin
Copy link
Member

ychin commented Dec 5, 2020

Yes that is correct. It does depend on where you get your Python from. For example the default Homebrew installation is still Rosetta based so if you are using that you would actually be getting the x86 version.

@netcaf
Copy link

netcaf commented Dec 5, 2020

@netcaf No there is no native Apple Silicon / M1 build yet, but you can use the current release under Rosetta. Is there a reason why you need a native Apple Silicon build? From what I have tried, Rosetta performance is decent enough that it should not make too big an impact.

Apple Silicon build will come out probably after the upcoming release, so probably release 168. If you use the binary release published in https://github.com/macvim-dev/macvim/releases the automatic updater will still work and upgrade you to Apple Silicon native builds in the future.

It's currently a little tricky to push out Apple Silicon builds due to lack of CI support hence the delay.

@ychin Thank you for the explanation. I have just got my MacBook m1 and is full of curiosity about the new experience. Macvim is my favorite app but it’s Ok I will try it with Rosetta.

Thank you all for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants