Fix popup test failure, and clean up MacVim error codes #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix failure in Test_popup_command. The test assumes a certain PopUp menu layout but we recently added a new "Look Up" menu item. Make sure the test removes those non-standard menu items before progressing the test. Also, while we are at it, make sure the showdefinition() command will fail when not in GUI mode so it doesn't queue up the command queue. Also, convert the E??? error codes to proper error codes (and using a postfix "-M" to make sure they don't conflict with future Vim error codes) so they can be looked up in documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failure in Test_popup_command. The test assumes a certain PopUp menu layout but we recently added a new "Look Up" menu item. Make sure the test removes those non-standard menu items before progressing the test.
Also, while we are at it, make sure the showdefinition() command will fail when not in GUI mode so it doesn't queue up the command queue. Also, convert the E??? error codes to proper error codes (and using a postfix "-M" to make sure they don't conflict with future Vim error codes) so they can be looked up in documentation.