Add CI / test checks to make sure we don't accidentally lose features #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The +sound check should fail, until vim/vim#11497 is merged. After that, this check will make sure this issue (sound being accidentally turned off) won't happen again. |
ychin
force-pushed
the
check-sound-sodium-ci
branch
2 times, most recently
from
5b52d2c to
eeaf175
Compare
Add CI test to confirm desired Vim features like +sound / etc exist. Smoketest also checks for libsodium now by trying to set xchacha20 cryptmethod which can only succeed if sodium is enabled. Also make sure it's actually checking the scripting language bindings are working properly. Previously for some reason it wasn't checking the print results.
ychin
force-pushed
the
check-sound-sodium-ci
branch
from
eeaf175 to
789d22c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI test to confirm desired Vim features like +sound / etc exist.
Smoketest also checks for libsodium now by trying to set xchacha20 cryptmethod which can only succeed if sodium is enabled. Also make sure it's actually checking the scripting language bindings are working properly. Previously for some reason it wasn't checking the print results.