Fix unnecessary ifdef when dealing with gettext #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirnym
approved these changes
Nov 27, 2022
When adding support for gettext in macvim-dev#1070, a MacVim-specific ifdef was added unnecessary around `bindtextdomain`. That ifdef isn't actually necessary and it seems to have been done due to an incorrect understanding of the ifdef logic there regarding `FEAT_GETTEXT`. Just remove it to clean it up. Localization should still work.
ychin
force-pushed
the
fix-unnecessary-bindtextdomain-ifdef
branch
from
0406fcf to
c2bb879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding support for gettext in #1070, a MacVim-specific ifdef was added unnecessary around
bindtextdomain. That ifdef isn't actually necessary and it seems to have been done due to an incorrect understanding of the ifdef logic there regardingFEAT_GETTEXT. Just remove it to clean it up. Localization should still work.