Allow Sparkle release notes to use JavaScript so videos work #1360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it's hard to embed video in the release notes shown to Sparkle, because by default it disables JavaScript, which video tags need in order to work properly for the WebKit embedded browser. Turn it on, so that we can show video instead of animated GIF's in the future for release notes. I don't think there should be any serious security issues after thinking about it. The browser is sandboxed and we are serving this through https anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's hard to embed video in the release notes shown to Sparkle, because by default it disables JavaScript, which video tags need in order to work properly for the WebKit embedded browser. Turn it on, so that we can show video instead of animated GIF's in the future for release notes.
I don't think there should be any serious security issues after thinking about it. The browser is sandboxed and we are serving this through https anyway.