Remove unnecessary MacVim-specific window clear #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During merging from upstream Vim, I noticed that MacVim is doing some unnecessary clears. From looking at them, I don't think they are really necessary (at least with the current source revision). Such MacVim-specific changes add merge conflicts and makes it difficult to diagnose issues (as we need to determine if they are MacVim-specific or Vim). Just remove it for now. Can always add back if we see issues. The change was introduced in c621846.
ychin
force-pushed
the
cleanup-window-clearing
branch
from
628555e to
776c73e
Compare
tono
pushed a commit
to tono/macvim
that referenced
this pull request
Jun 19, 2023
Remove unnecessary MacVim-specific window clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During merging from upstream Vim, I noticed that MacVim is doing some unnecessary clears. From looking at them, I don't think they are really necessary (at least with the current source revision). Such MacVim-specific changes add merge conflicts and makes it difficult to diagnose issues (as we need to determine if they are MacVim-specific or Vim). Just remove it for now. Can always add back if we see issues.
The change was introduced in c621846.