Skip to content

Add make target to sign with ad-hoc signature with correct entitlements #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ychin merged 1 commit into from
Jul 23, 2025
Merged

Add make target to sign with ad-hoc signature with correct entitlements #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions src/MacVim/scripts/sign-developer-id
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,46 +2,55 @@

# Utility script to sign MacVim with a valid Developer ID with hardened runtime
# along with a provided entitlments file. This script requires a Developer ID
# cert already installed on the computer.
# cert already installed on the computer, unless only making adhoc signatures.

# Use the following to verify:
# codesign -d --verbose=4 --entitlements - <MacVim_app>

if [[ $# == 0 || $# == 1 ]]; then
echo "Usage: sign-developer-id <MacVim_app> <entitlements_file>"
echo "Usage: sign-developer-id [--adhoc] <MacVim_app> <entitlements_file>"
exit -1
fi

set -e

signature_identity="Developer ID Application"

if [[ "$1" == "--adhoc" ]]; then
# Create an adhoc signature. This is useful for local testing, but cannot
# generate a valid signed app that you could distribute to other people.
signature_identity="-"
shift
fi

macvim_path=$1
entitlements=$2

if [[ "$macvim_path" =~ dmg ]]; then
set -x
codesign -f -s "Developer ID Application" -o runtime --timestamp "$macvim_path"
codesign -f -s "$signature_identity" -o runtime --timestamp "$macvim_path"
else
# Sign bottom-up to make sure everything is signed in order.
# Note: Not using --deep because it's been deprecated since macOS 13, and
# also it doesn't catch all the binaries anyway so it's better to just be
# explicit and sign everything in order to be clear what we are doing.
if [ -d "$macvim_path/Contents/Frameworks/Sparkle.framework/Versions/A" ]; then
(set -x
codesign -f -s "Developer ID Application" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupdate.app/Contents/MacOS/fileop"
codesign -f -s "Developer ID Application" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupdate.app")
codesign -f -s "$signature_identity" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupdate.app/Contents/MacOS/fileop"
codesign -f -s "$signature_identity" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework/Versions/A/Resources/Autoupdate.app")
fi
if [ -d $macvim_path/Contents/Frameworks/Sparkle.framework/Versions/B ]; then
(set -x
codesign -f -s "Developer ID Application" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework/Versions/B/Autoupdate"
codesign -f -s "Developer ID Application" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework/Versions/B/Updater.app")
codesign -f -s "$signature_identity" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework/Versions/B/Autoupdate"
codesign -f -s "$signature_identity" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework/Versions/B/Updater.app")
fi
if [ -d $macvim_path/Contents/Frameworks/Sparkle.framework ]; then
(set -x
codesign -f -s "Developer ID Application" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework")
codesign -f -s "$signature_identity" -o runtime --timestamp "$macvim_path/Contents/Frameworks/Sparkle.framework")
fi
set -x
codesign -f -s "Developer ID Application" -o runtime --timestamp "$macvim_path/Contents/Library/QuickLook/QLStephen.qlgenerator/Contents/MacOS/QLStephen"
codesign -f -s "Developer ID Application" -o runtime --timestamp --entitlements $entitlements "$macvim_path/Contents/bin/xxd"
codesign -f -s "Developer ID Application" -o runtime --timestamp --entitlements $entitlements "$macvim_path/Contents/MacOS/Vim"
codesign -f -s "Developer ID Application" -o runtime --timestamp --entitlements $entitlements "$macvim_path"
codesign -f -s "$signature_identity" -o runtime --timestamp "$macvim_path/Contents/Library/QuickLook/QLStephen.qlgenerator/Contents/MacOS/QLStephen"
codesign -f -s "$signature_identity" -o runtime --timestamp "$macvim_path/Contents/bin/xxd"
codesign -f -s "$signature_identity" -o runtime --timestamp --entitlements $entitlements "$macvim_path/Contents/MacOS/Vim"
codesign -f -s "$signature_identity" -o runtime --timestamp --entitlements $entitlements "$macvim_path"
fi
5 changes: 4 additions & 1 deletion src/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3773,7 +3773,7 @@ Makefile:

##############################################################################
### MacVim GUI
.PHONY: macvim macvim-dmg macvim-dmg-legacy macvimclean macvim-signed macvim-dmg-release macvim-dmg-release-legacy macvim-install-runtime macvim-xcodeproj-compat
.PHONY: macvim macvim-dmg macvim-dmg-legacy macvimclean macvim-signed macvim-signed-adhoc macvim-dmg-release macvim-dmg-release-legacy macvim-install-runtime macvim-xcodeproj-compat

RUNTIME_FOLDER_LIST = MacVim/auto/runtime_folder_list.xcfilelist

Expand Down Expand Up @@ -3803,6 +3803,9 @@ macvim-tests:
macvim-signed:
MacVim/scripts/sign-developer-id $(RELEASEDIR)/MacVim.app $(ENTITLEMENTS)

macvim-signed-adhoc:
MacVim/scripts/sign-developer-id --adhoc $(RELEASEDIR)/MacVim.app $(ENTITLEMENTS)

macvim-dmg-legacy: DMGFILESYSTEM = HFS+
macvim-dmg-legacy: DMGFORMAT = UDZO
macvim-dmg-legacy: macvim-dmg
Expand Down
Loading