Use a custom I-beam mouse cursor for pre-Mojave OS versions #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevoiusly, macvim-dev#859 removed the custom high-contrast I-beam mouse cursor in favor of using the system-default I-beam cursor. However, it mostly worked well on 10.14 Mojave or above, as the cursor is designed with dark mode in mind and works well on both bright and dark backgrounds. Since this doesn't work well on older macOS versions, add back the custom cursor and only enable it on those older macOS versions. Fix macvim-dev#910.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevoiusly, #859 removed the custom high-contrast I-beam mouse cursor in favor of using the system-default I-beam cursor. However, it mostly worked well on 10.14 Mojave or above, as the cursor is designed with dark mode in mind and works well on both bright and dark backgrounds. Since this doesn't work well on older macOS versions, add back the custom cursor and only enable it on those older macOS versions.
Fix #910.