Fix hardcoded TinyStories data path in train_large/train_large_ane#29
Merged
maderix merged 1 commit intomaderix:mainfrom Mar 4, 2026
Merged
Conversation
Owner
|
Thanks — threading --data through execl() restarts was the tricky part and you got it right. Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I worked on this
First, thank you for building this project. ANE is honestly awesome, and I’m actively using it in real workflows.
I’m running these training pipelines as part of my Open Claw agent environment across multiple Apple machines and different launch contexts (manual runs, scripted runs, and restart-driven runs). In that setup, I kept hitting the same issue: the static trainers expected token data at a fixed path.
The run would work in one context, then break in another, and it could also fail after
exec()restart because the path context was not explicit. That created unnecessary friction for real usage and for onboarding other people.What this PR changes
--data PATHtotrain_largeandtrain_large_ane--dataacrossexec()restart so resumed training keeps the same datasettraining/README.mdwith examples and flag documentationWhy this helps the community
Validation
I validated this on Apple Silicon macOS with explicit absolute paths:
train_large --steps 11 --data <abs-path>(forces restart path)train_large_ane --no-ane-extras --steps 11 --data <abs-path>(same restart validation)Both restart paths resumed correctly and continued reading token data as expected.
Personal note
I’m very excited about this project and would love to keep contributing to its growth. I’ve contributed multiple times to Open Claw, and I’m using ANE in serious, practical workflows, so I plan to keep sending real-world fixes and useful benchmark data upstream.