Git + GitHub additional skill #41
Conversation
craigjbass
force-pushed
the
git-additional-skill
branch
from
c85fede to
bf816c1
Compare
| * Demonstrate setting the default upstream branch for a local branch | ||
| * Demonstrate force pushing rebases into isolated upstream Pull Request branches | ||
|
|
||
| ## GitHub |
There was a problem hiding this comment.
I couldn't think of anything else of interest on here. Maybe commenting?
There was a problem hiding this comment.
Demonstrate appropriate rebasing of isolated branches assuming this means rebasing/squashing commit history?
There was a problem hiding this comment.
Don't merge a branch with 50 commits
There was a problem hiding this comment.
Words to live by.
There was a problem hiding this comment.
Perhaps something around PR etiquette, but I don't really have anything to add. LGTM!
|
Git ignore missing |
|
Identifying files to ignore |
|
Etiquette around getting reviews / useful practices around leaving reviews |
|
Ensure all commits pass tests |
|
Seems more etiquette, not using git. Useful to know, but not core git? |
StevenLeighton21
left a comment
StevenLeighton21
left a comment
There was a problem hiding this comment.
General approval from me.
| ## Initializing | ||
|
|
||
| * Demonstrate initializing a new git repository | ||
| * Demonstrate creating an empty root commit |
There was a problem hiding this comment.
Had not thought about doing this, nice.
| * Demonstrate usage of `git status` | ||
| * Demonstrate staging files for commit | ||
| * Demonstrate committing staged files | ||
| * Demonstrate committing a subset of changed files using staged and unstaged files |
There was a problem hiding this comment.
How about staging only a subset of a file?
| * Demonstrate doing a simple rebase of master onto a branch | ||
| * Demonstrate performing an amend to previous commit | ||
| * Demonstrate performing an interactive rebase of a branch | ||
| * Demonstrate using all possible rebase options |
There was a problem hiding this comment.
Not sure what I’d be assessing here.
Scrap that I understand now, all the interactive rebase options.
|
Needs something about what a good commit message looks like. |
|
Going to merge and address commit messages in upcoming |
No description provided.