Skip to content

Conversation

@stengerh
Copy link
Collaborator

@stengerh stengerh commented Jul 2, 2015

An attempt at preserving - or rather restoring - the scroll position in the JavaFX based preview. The preview may flicker or jerk to the top while the updated HTML loads. This effect may be unnoticeable on short documents which appear to update instantly. Embedded images make the effect very noticeable, especially if they are loaded from a remote server

See also #42.

@madflow
Copy link
Owner

madflow commented Jul 12, 2015

I tested the changes with this document: http://daringfireball.net/projects/markdown/index.text

I can reproduce the restored scroll position - but only in the first few sections. When I scroll down to approx. "Blosxom" in the document and switch from preview to editor and back - I always end up at the top again. I am on Linux machine.

@stengerh
Copy link
Collaborator Author

Thanks for the feedback! I tested this on Windows 8.1 with the source and preview views side-by-side in a split editor window. I'll look into it.

@stengerh
Copy link
Collaborator Author

This issue should be fixed now.

Note to self: remember to think twice before using MessageFormat to generate program code. It includes thousands separators by default.

madflow added a commit that referenced this pull request Jul 14, 2015
@madflow madflow merged commit 18825e4 into madflow:nb8 Jul 14, 2015
@madflow
Copy link
Owner

madflow commented Jul 14, 2015

Thanks! I tested some more and it looks fine. I went ahead and merged the PR for easier collaborative testing (feel free to use your merge rights in the future ;) )

@stengerh
Copy link
Collaborator Author

Okay, I had deliberately used a pull request to enable discussion about the proposed changes. ;)

@stengerh stengerh deleted the feature-preview-scroll-position-nb8 branch July 14, 2015 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants