Skip to content

add missing json info, add possibility in perf.py to plot a compariso…#61

Merged
roiser merged 1 commit intomadgraph5:masterfrom
roiser:complete-json
Nov 30, 2020
Merged

add missing json info, add possibility in perf.py to plot a compariso…#61
roiser merged 1 commit intomadgraph5:masterfrom
roiser:complete-json

Conversation

@roiser
Copy link
Member

@roiser roiser commented Nov 24, 2020

adds missing info in json and a change in perf.py plotting for adding a cpu value in the 2d plots

@roiser roiser requested a review from valassi November 24, 2020 07:30
@oliviermattelaer
Copy link
Member

included in epoch2 PR

Copy link
Member

@valassi valassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Stefan,
by just looking superficially at the code, I see nothing controversial. Then I have not tested the json output or the json plotting. Maybe one thing that could eventually be improved is to keep in sync the json and stdout in a stringer way, using a single outputting code, but i may be a complex overkill. Just go ahead and merge.
Thanks Andrea

@roiser roiser merged commit 2582e36 into madgraph5:master Nov 30, 2020
@valassi
Copy link
Member

valassi commented Nov 30, 2020

Ah sorry, should have checked

check.cc: In function ‘int main(int, char**)’:
check.cc:505:10: warning: unused variable ‘stdwtim’ [-Wunused-variable]
   double stdwtim = std::sqrt( sqswtim / niter - meanwtim * meanwtim );
          ^~~~~~~

Maybe just comment out the line if not needed?
Thanks

valassi added a commit to valassi/madgraph4gpu that referenced this pull request Nov 30, 2020
valassi added a commit that referenced this pull request Nov 30, 2020
Fix build warning from #61 (comment out stdwtim)
@roiser roiser deleted the complete-json branch December 14, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants