add missing json info, add possibility in perf.py to plot a compariso…#61
Merged
roiser merged 1 commit intomadgraph5:masterfrom Nov 30, 2020
Merged
add missing json info, add possibility in perf.py to plot a compariso…#61roiser merged 1 commit intomadgraph5:masterfrom
roiser merged 1 commit intomadgraph5:masterfrom
Conversation
Member
|
included in epoch2 PR |
valassi
approved these changes
Nov 30, 2020
Member
valassi
left a comment
There was a problem hiding this comment.
Hi Stefan,
by just looking superficially at the code, I see nothing controversial. Then I have not tested the json output or the json plotting. Maybe one thing that could eventually be improved is to keep in sync the json and stdout in a stringer way, using a single outputting code, but i may be a complex overkill. Just go ahead and merge.
Thanks Andrea
Member
|
Ah sorry, should have checked Maybe just comment out the line if not needed? |
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Nov 30, 2020
valassi
added a commit
that referenced
this pull request
Nov 30, 2020
Fix build warning from #61 (comment out stdwtim)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds missing info in json and a change in perf.py plotting for adding a cpu value in the 2d plots