Adding HIP/CUDA Abstraction to CODEGEN and gg_ttgg.mad#774
Closed
Jooorgen wants to merge 19 commits intomadgraph5:masterfrom
Closed
Adding HIP/CUDA Abstraction to CODEGEN and gg_ttgg.mad#774Jooorgen wants to merge 19 commits intomadgraph5:masterfrom
Jooorgen wants to merge 19 commits intomadgraph5:masterfrom
Conversation
…rc.mk and cudacpp.mk
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jan 25, 2024
I am working now in branch valassi/jthip24. This is my first commit over joorgen/gpu_abstraction branch (also known as valassi/jthip), as of commit 229ffeb (Tue Aug 15 11:33:01 2023 +0200). This branch contains fewer features than jooorgen/master (PR madgraph5#718), but it is more advanced than joorgen/gpu_abstraction_only (PR madgraph5#774). I will probably need some of the commits here to fix PR madgraph5#774 in branch valassi/jt774. I regenerate the ten processes as follows: ./CODEGEN/generateAndCompare.sh ee_mumu --mad ./CODEGEN/generateAndCompare.sh gg_tt --mad ./CODEGEN/generateAndCompare.sh gg_ttg --mad ./CODEGEN/generateAndCompare.sh gg_ttgg --mad ./CODEGEN/generateAndCompare.sh gg_ttggg --mad ./CODEGEN/generateAndCompare.sh ee_mumu ./CODEGEN/generateAndCompare.sh gg_tt ./CODEGEN/generateAndCompare.sh gg_ttg ./CODEGEN/generateAndCompare.sh gg_ttgg ./CODEGEN/generateAndCompare.sh gg_ttggg These are the five processes that would get conflicts when I merge upstream/master here, so I guess that these are the only ten processes touched in this branch. The fact that I can regenerate them and there are no real differences (except for irrelevant stuff like me5_configuration.txt, aloha_file.inc, py3_model.pkl) shows that ALL IMPORTANT CHANGES BY JORGEN HERE ARE IN THE CODEGEN. I can therefore merge upstream/master, fix conflicts in CODEGEN and regenerate.
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jan 25, 2024
(NB: this code does not build instead in branch jt774 based on PR madgraph5#774)
Member
|
Hi @oliviermattelaer @roiser @nscottnichols , as discussed, I am closing this one as it is replaced by PR #801 (which is based on it but also merges upstream/master and includes frurther fixes and tests). Alternatively I can reopen it and merge it to my jt774 branch if you prefer... so at least it is clear that this work was used. Thanks to @Jooorgen! |
This was referenced Jan 28, 2024
valassi
added a commit
that referenced
this pull request
Jan 31, 2024
Jorgen's addition of HIP/CUDA abstraction to codegen and all processes (with extra fixes and tests: "jt774" replacing PR #774) - merge now as approved by Olivier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the HIP/CUDA GPU abstraction.