Fix issues in the new CI (tput_test was not executed)#938
Merged
valassi merged 4 commits intomadgraph5:masterfrom Jul 24, 2024
Merged
Fix issues in the new CI (tput_test was not executed)#938valassi merged 4 commits intomadgraph5:masterfrom
valassi merged 4 commits intomadgraph5:masterfrom
Conversation
…ne gg_tt "new ci" test while debugging madgraph5#937
…test CI issue madgraph5#937 and add debug printouts
…' by 'ECHO' alias to leave a blank line (workaround for github issue)
…adgraph5#927 Revert "[actions] in .github/workflows, TEMPORARELY reduce CI tests to only one gg_tt "new ci" test while debugging madgraph5#937" This reverts commit 5b71191.
valassi
changed the title
Member
Author
|
Hi @oliviermattelaer can you please review? This should be totally non controversial, just fixing the new CI where one test was not running (and also fixing the printout in the CI) Thanks Andrea PS The usual 6 tests failing |
Member
|
No time to look at it. But no objection to merge it if it is only fixing tests. I trust your judgment
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Andrea Valassi ***@***.***>
Sent: Wednesday, July 24, 2024 11:53:12 AM
To: madgraph5/madgraph4gpu ***@***.***>
Cc: Olivier Mattelaer ***@***.***>; Review requested ***@***.***>
Subject: Re: [madgraph5/madgraph4gpu] Fix issues in the new CI (tput_test was not executed) (PR #938)
@valassi<https://github.com/valassi> requested your review on: #938<#938> Fix issues in the new CI (tput_test was not executed).
—
Reply to this email directly, view it on GitHub<#938 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AH6535SILVCKXANL2A2ZW53ZN52QRAVCNFSM6AAAAABLKVPVW6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGYZDOOJTGI3DEMQ>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Member
Author
Thanks Olivier :-) Very good, I will merge this shortly, so we have one less to keep track of. (Hopefully it will not expose more issues in the other PRs, but who knows, that's the whole point) |
Member
Author
|
Merging now |
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jul 24, 2024
…am/master' (including CI fixes PR madgraph5#938) into june24
valassi
added a commit
to valassi/madgraph4gpu
that referenced
this pull request
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP investigate CI issues #937