Skip to content
This repository was archived by the owner on Dec 22, 2025. It is now read-only.

Conversation

@katcipis
Copy link
Member

@katcipis katcipis commented Oct 6, 2022

Use testing.TB on asserts so they can be used on benchmarks. Also fixes a bug on assert messages.

@katcipis katcipis requested a review from i4ki October 6, 2022 21:47
@katcipis katcipis self-assigned this Oct 6, 2022
i4ki
i4ki previously approved these changes Oct 7, 2022
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #22 (6c55657) into main (600dcdc) will increase coverage by 2.28%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   77.41%   79.69%   +2.28%     
==========================================
  Files          11       11              
  Lines         518      522       +4     
==========================================
+ Hits          401      416      +15     
+ Misses        114      102      -12     
- Partials        3        4       +1     
Flag Coverage Δ
tests 79.69% <50.00%> (+2.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
assert/error.go 18.51% <0.00%> (+18.51%) ⬆️
assert/partial.go 80.00% <0.00%> (ø)
assert/string.go 28.57% <0.00%> (ø)
assert/equal.go 43.05% <16.66%> (+8.33%) ⬆️
assert/assert.go 85.00% <100.00%> (+1.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@katcipis katcipis requested a review from i4ki October 7, 2022 10:48
@katcipis katcipis merged commit 8ce6c95 into main Oct 7, 2022
@katcipis katcipis deleted the katcipis-use-tb branch October 7, 2022 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants