Make building examples optional #441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Build errors on iOS up going away, either due to zlib or Xcode upgrades since then. Closing this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not directly programming with zlib, I'm just building it to satisfy the dependency in SDL2. Therefore, I have no reason to build the 'example' and 'minigzip' executables.
In addition, I get build errors on iOS if I don't have the following target properties set:
MACOSX_BUNDLE TRUE
XCODE_ATTRIBUTE_CODE_SIGN_IDENTITY
XCODE_ATTRIBUTE_DEVELOPMENT_TEAM
The first property would be easy to set in zlib, but the last two are unique to my Apple dev account and while it could be a variable I could pass into zlib, I think the cleaner and more generic way is just to have options available to disable building these executables altogether.
So I've added BUILD_ZLIB_EXAMPLE and BUILD_ZLIB_MINIGZIP options that I've set to ON by default. This will ensure no behavior change by default. In an upstream CMake file in my project, I've set them to off so they no longer build.