Skip to content

Conversation

@bmarques1995
Copy link
Contributor

CMake is complaining of a very low cmake support version, so is recommended upgrade its version

@fredgan
Copy link

fredgan commented Mar 28, 2023

No other effects or modifications?

@bmarques1995
Copy link
Contributor Author

No other effects or modifications?

No, only this one

@fredgan
Copy link

fredgan commented Mar 28, 2023

So, the CMake versions are more widely covered, I don't understand what the complaint is.

@bmarques1995
Copy link
Contributor Author

So, the CMake versions are more widely covered, I don't understand what the complaint is.

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 2.8.12 will be removed from a future version of
CMake.

Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.

@tbeu
Copy link
Contributor

tbeu commented Jun 1, 2023

Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.

Could set cmake_minimum_required(VERSION 2.4.4...3.0.0) alternatively.

@tbeu
Copy link
Contributor

tbeu commented Jun 1, 2023

See also #774.

@bmarques1995 bmarques1995 requested a review from nmoinvaz June 3, 2023 20:21
@Neustradamus Neustradamus mentioned this pull request Aug 14, 2023
@vszakats
Copy link

vszakats commented Aug 16, 2023

CMake 3.27.0 released on 2023-07-18 warns if the minimum version is below 3.5:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Might make sense to bump to 3.5 to avoid this.

@bmarques1995
Copy link
Contributor Author

Now the max is 3.15.0

@madler
Copy link
Owner

madler commented Aug 17, 2023

Applied.

@madler madler closed this Aug 17, 2023
@Neustradamus
Copy link

Merged commit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants