fix: multiple crashes, threading problem and scoping inconsistency within functions#103
Merged
mads-risager merged 6 commits intomainfrom May 22, 2023
Merged
fix: multiple crashes, threading problem and scoping inconsistency within functions#103mads-risager merged 6 commits intomainfrom
mads-risager merged 6 commits intomainfrom
Conversation
sabotack
changed the title
sabotack
changed the title
mads-risager
approved these changes
May 22, 2023
sabotack
changed the title
sabotack
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes writeScreenOpeningData in entity class does not use overloaded writeString method of PacketByteBuf #96
overloaded writeString method is used instead
fixes writeNbt and readNbt in entity can crash client due to limited characters #97
if input is larger than 50K it is split into multiple strings to bypass writeNbt string max limit
fixes calling Print in infinite loop without delay crashes client #100
1ms delay added, enough to not overload server, but print still feels instant
fixes function parameters are only defined in first scope #101
scope stack is checked recursively to find shadowed symbols
fixes entity is always null when receiving StopInterpreterC2SPacket #102
thread is stopped using the safer interrupt method, this throws an exception which is handled in the interpreter class and allows the thread to end naturally.