You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Didn't really realize this before, but making type OpaqueData = UnsafeCell<...> actually means that Id<T, Shared> is much safer!
Having aliasing Id<T, Owned> and Id<T, Shared> is ofc. still UB, but if you only use Id<T, Shared> and don't implement Send and/or Sync on your type then Objective-C methods are free to mutate the object as much as they want!
(Concretely, this removes a few noalias and readonly attributes from the LLVM IR of e.g. &Object and &Class, just like using an extern type for those would)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingI-unsoundA soundness hole, or affecting soundness
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.