extern_class! macro#188
Merged
Merged
Conversation
madsmtm
added
enhancement
3 tasks
madsmtm
force-pushed
the
extern-class-macro
branch
3 times, most recently
from
a0a75ee to
18bae76
Compare
madsmtm
force-pushed
the
extern-class-macro
branch
from
18bae76 to
c4a660f
Compare
Owner
Author
|
See also prior art in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken out of #161.
Rename
object!macro toextern_class!, usederivedirectly for things that can be derived (instead of us having to implementPartialEqand so on manually), and expose the macro publicly.This macro will greatly help consumers create their own Objective-C classes. For example, I'd like to use this in
winitto define safe abstractions overNSApplication,NSWindow,NSView,NSResponerand so on.A few
Debugimpls got worse from this change (since they now show the inheritance chain instead of just usingdescription), but they weren't terribly important in the first place, and should be fixed properly at some point anyhow (e.g.NSArray'sDebugimpl should attempt to show the contents), so eh.NSStringandNSMutableStringstill have proper implementations.