Consistently implement MethodImplementation wrt. lifetimes#193
Merged
Conversation
Previously, the receiver's lifetime was higher-ranked, while the rest of the arguments weren't, which meant that: - Their type could not be inferred like the other arguments - Having a return type with a lifetime bound to the receiver was impossible Fixes upstream SSheldon/rust-objc#12, at least as far as possible right now. This is a breaking change, and is unfortunately difficult for users to know how to fix, not really sure how to improve that situation?
madsmtm
added
bug
This was referenced Jul 7, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #30. This is required for #190.
Fixes upstream SSheldon/rust-objc#12, see that for more details.
Previously, the receiver's lifetime was higher-ranked, while the rest of the arguments weren't, which meant that:
This is a breaking change (can't avoid that, lest we run into a future-compat error), and is unfortunately difficult for users to know how to fix, not really sure how to improve that situation?