Add NSSet and NSMutableSet#245
Merged
Merged
Conversation
madsmtm
reviewed
Aug 17, 2022
Owner
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Wow, this looks really nice!
I don't have time for it right now, but will review it in about a week
madsmtm
reviewed
Aug 17, 2022
zleytus
force-pushed
the
nsset
branch
3 times, most recently
from
fb6408f to
282b0f7
Compare
madsmtm
requested changes
Aug 17, 2022
Owner
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Turns out, I got a bit of time to do it now: Looks really nice, especially cool with the detailed examples!
zleytus
force-pushed
the
nsset
branch
2 times, most recently
from
44aa2ee to
ade656c
Compare
madsmtm
requested changes
Aug 28, 2022
Owner
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Thanks, just one more thing then I think it's good to go
Contributor
Author
|
I just noticed this change 1b32385 for |
Owner
|
Yeah, |
madsmtm
approved these changes
Aug 29, 2022
madsmtm
pushed a commit
that referenced
this pull request
Jan 12, 2026
* It closes #245, Increases the foreign-type version, Adds a new example for showing raytracing capabilities in metal 3. CI action version increase code improvement in foreign_obj_type macro. And adding several other needed features in the code. * Increases the version of the Rust * Build fix for mps module and a warning has been removed. * fixing the build for stable * cargo test fix * a little doc * All of the uniquely borrowed refrences removed. * several warning fixed in the ratracing example, it was due to the recent change in the API * All the modules now private again and only the mps one is public.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSSetandNSMutableSethave a lot in common withNSArrayandNSDictionary, so they were relatively straightforward to add.Part of #67.