Add NSMutableDictionary#249
Merged
Merged
Conversation
zleytus
force-pushed
the
nsmutabledict
branch
3 times, most recently
from
3984990 to
3abaa22
Compare
madsmtm
approved these changes
Aug 29, 2022
Owner
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Looks good, only minor nits.
Out of curiosity, may I ask your reasoning for contributing to this repo? I couldn't find a project on your GitHub page, but I assume you need this for something?
Contributor
Author
|
I'm planning to use this library to wrap CoreWLAN and eventually write a cross-platform Wi-Fi library. CoreWLAN returns Wi-Fi scan results in an |
Owner
|
Oooh, interesting! Do drop me a note somewhere when you have something to show, I would be glad to give it a soundness review. |
Contributor
Author
|
Definitely! That would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes sense to add
NSMutableDictionaryto go withNSDictionary.Part of #67.