Conversation
Previously UnwindSafe required `RefUnwindSafe + UnwindSafe`, but this is unnecessarily restrictive. And WeakId was !RefUnwindSafe
Removed previously in 4118e96, but embedded drop flags are gone so this is no longer an issue. Fixes SSheldon/rust-objc-id#1 Co-authored-by: Steven Sheldon <steven@sasheldon.com>
This was referenced Oct 8, 2021
madsmtm
force-pushed
the
id-traits
branch
2 times, most recently
from
5ac9146 to
4955e5c
Compare
There is more boilerplate to come, and it makes it hard to focus on the actually interesting stuff
- Read - Write - Seek - BufRead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strive to implement the traits that
BoxandArcdoes.Additionally, for the traits that returnSelf(likeFromandDefault), add additional traits that can help with that functionality in downstream crates (likeobjc2_foundation). Should solve #39 as far as possible.Add additional helper trait
DefaultIdfor implementingDefaultonIdin downstream crates. Part of #39, the rest has been postponedErrorimpl forId.UnwindSafeimpls.IdSlicetrait.HasheriotraitsFutureDefaultIdAddPostponedFromId/IntoIdAddPostponedTryFromId/TryIntoId