Refactor objc2_encode#412
Merged
Merged
Conversation
b3e2c35 to
a7778ca
Compare
a7778ca to
f6466ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the traits in it to
objc2::encode, and make itno_stdand target/platform-agnostic. I also fixed bitfields along the way.Now,
objc2_encodejust contains the parsing/representation of encodings (which may be usable elsewhere, e.g. in an Objective-C compiler or something).This is done because I've found that keeping the
Encode/RefEncode/EncodeConverttraits in a separate crate than the rest ofobjc2is just too much of a hassle, and a blocker for #277.Downside is that
block2now depends onobjc2instead of justobjc2-encode, which makes the compilation graph slightly worse, but eh, on the other handobjc2-encodenow has no dependencies.