Work towards removing malloc_buf#547
Merged
Merged
Conversation
madsmtm
added
enhancement
madsmtm
force-pushed
the
deprecate-malloc-buf
branch
2 times, most recently
from
4ec0358 to
9db2b06
Compare
madsmtm
force-pushed
the
deprecate-malloc-buf
branch
from
9db2b06 to
ba3b5be
Compare
Owner
Author
|
Note that this added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
malloc_bufis unmaintained and unsound, and may be marked as such in the Rustsec Advisory Database in the future, which would be bad for our users; so we should really migrate to something else.The alternatives
mbox,mallocedandmalloc-arrayare either also unsound (usually failing to handle0-length arrays properly), or not popular/maintained enough for me to be comfortable with them as a dependency.So let's just roll our own implementation, it's not really that complex anyhow (since we don't handle allocation, only deallocation), and we should be able to swap it out with
Box<_, MallocAllocator>in the future.Part of #500.