Fix block2 memory management#568
Merged
Merged
Conversation
6c290ec to
46a70d7
Compare
46a70d7 to
216efbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #168. Fixes upstream SSheldon/rust-block#9.
The way
block2currently works is that you create theStackBlock, and then you must callcopyto convert it to anRcBlock. This is very error-prone, especially since you can't ensure that Objective-C doesn't call_Block_copywhen you pass your stack block to an external function, so forgetting to callcopyusually ends up causing double-frees.Instead, we should implement
StackBlockto useCloneonce_Block_copyis called, and for the cases where that's impossible, the user should construct theRcBlockdirectly.Clang notes: In ARC-enabled Clang, it is impossible to get the equivalent of
StackBlock, since it effectively always does a.to_rc()on creation. Non-ARC Clang puts the block on the stack, and you're expected to callBlock_copyyourself.