Conversation
madsmtm
added
enhancement
madsmtm
force-pushed
the
cf
branch
4 times, most recently
from
515acb0 to
acd2783
Compare
Co-authored-by: samuelsleight <samuel.sleight@gmail.com> Co-authored-by: silvanshade <silvanshade@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #556.
This was... Actually a lot easier than I thought it would be, at least nowadays - though part of that is that we're very much skimping on actually generating useful definitions, i.e.
CF*Refs are currently just typedefs to*mut c_void, but that can be improved later.Huge thanks to @silvanshade and @samuelsleight, I've taken a bunch of commits from #400 and #471.
NOTE: This does have the disadvantage that using types like
CGPointnow requiresCoreFoundation, but there isn't much we can do about it, as the correct place for these types to live really isCoreFoundation. (I guess we could add extra type-aliases forCGFloat, but I really wanted to land this PR, so I didn't want to block on a future improvement like that).