Send and Sync fixes#94
Merged
Merged
Conversation
madsmtm
force-pushed
the
send-sync-fixes
branch
from
2085146 to
c58fdac
Compare
The change to OpaqueData is to make types !UnwindSafe by default
Similar to objc2::runtime::Object
madsmtm
force-pushed
the
send-sync-fixes
branch
from
c58fdac to
e478974
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19 made
objc2::runtimetypes!Send,!Sync,!Unpin,!UnwindSafeand!RefUnwindSafe.This PR rectifies that for:
Ivar,Method,ClassandProtocol.Objectis intentionally still!Sendand!Sync, since its subclasses are not guaranteed to be thread safe.