fix graph.formula()#6
Merged
maelle merged 1 commit intozzz-decemberfrom Jan 12, 2024
Merged
Conversation
Owner
Author
|
@krlmlr if this is ok, I'll integrate it to the PR in igraph/rigraph (which I'll then have to rebase) |
Owner
Author
|
But I'd do the rebasing at the very very end since this is not an automatic change, or I'd edit the script to make this a special case in the automatic PR creation. |
|
I merged the better part of your big PR already, only two commits are remaining. Do we really need to rerun the script? I'd be fine with manual changes. Am I missing anything? |
|
Yes, this is what I mean by "inlining a function". |
Owner
Author
Aaaah this makes sense now, thanks. Some of them are a bit long so I'll have to think about how to best do it (later this week or next) I realized later manual changes would be fine. |
maelle
added a commit
that referenced
this pull request
Jan 12, 2024
maelle
added a commit
that referenced
this pull request
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of a hack, but it works to simply do what
graph_from_literal()does.Created on 2024-01-08 with reprex v2.0.2