feat(bake-oci-manifests): add teleport-token + kustomization-path inputs#6
feat(bake-oci-manifests): add teleport-token + kustomization-path inputs#6GureevLeonid wants to merge 1 commit into
Conversation
Two optional inputs to support monorepos where the canonical defaults don't fit: - `teleport-token` (default: `image-push-github-actions-<service>`) — override when one bot serves multiple services from a single repo, e.g. `image-push-github-actions-mindbox-mta` for `campaigns` (and eventually `mta`) inside maestra-io/Mindbox.MTA. - `kustomization-path` (default: `./kustomization`) — override when a monorepo keeps each service's manifests under its own subdir, e.g. `kustomization/campaigns`. The action's substitute + flux-push steps both honour the path. Backward compatible: existing callers (db-migrator already in production) keep working unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughExtended the bake-oci-manifests GitHub composite action to support configurable kustomization paths and dynamic Teleport token derivation. The action now accepts ChangesBake OCI manifests enhancements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
182-182: ⚡ Quick winConsider clarifying that the bot name must match the
teleport-tokenvalue.The prerequisite describes the default bot naming convention but doesn't mention that monorepo users overriding
teleport-tokenneed a bot provisioned with the overridden name instead. While technically accurate for the default case, adding a brief note would help monorepo users understand they needteleport-token-matching bots.📝 Optional clarification
-2. A Teleport bot named `image-push-github-actions-<service>` is provisioned on `teleport.maestra.io` with permission to mint workload-identity JWTs for the `image-push` selector against `sts.amazonaws.com`. +2. A Teleport bot matching the `teleport-token` value (default: `image-push-github-actions-<service>`) is provisioned on `teleport.maestra.io` with permission to mint workload-identity JWTs for the `image-push` selector against `sts.amazonaws.com`.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` at line 182, Update the README prerequisite to explicitly state that the Teleport bot name must match the configured teleport-token value when users override it; mention the default bot `image-push-github-actions-<service>` is only correct for the default teleport-token, and if a monorepo user sets a different `teleport-token` they must provision a bot with that exact name (the bot must still have permission to mint workload-identity JWTs for the `image-push` selector against `sts.amazonaws.com`).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@README.md`:
- Line 182: Update the README prerequisite to explicitly state that the Teleport
bot name must match the configured teleport-token value when users override it;
mention the default bot `image-push-github-actions-<service>` is only correct
for the default teleport-token, and if a monorepo user sets a different
`teleport-token` they must provision a bot with that exact name (the bot must
still have permission to mint workload-identity JWTs for the `image-push`
selector against `sts.amazonaws.com`).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 24983f48-7c53-481a-97e1-7e0a9021bbbc
📒 Files selected for processing (2)
README.mdbake-oci-manifests/action.yml
Summary
Two new optional inputs on the `bake-oci-manifests` composite action so monorepos can use it too:
Both are backward-compatible: the 1 production caller (db-migrator) keeps working unchanged.
Test plan
🤖 Generated with Claude Code
Changes
Added two optional inputs to the
bake-oci-manifestscomposite action to support monorepo setups:teleport-token: Allows overriding the derived default Teleport join token (defaults toimage-push-github-actions-<service>if not provided). Useful in monorepos where the Teleport bot name differs from the service name (e.g., forcampaignsservice in a monorepo, the bot may be namedimage-push-github-actions-mindbox-mta).kustomization-path: Allows overriding the default Kustomization manifest root path (defaults to./kustomization). Useful in monorepos that store each service's manifests under subdirectories likekustomization/<service>/.Updated components:
bake-oci-manifests/action.yml: Added input definitions and integrated them into the Teleport JWT minting and placeholder substitution steps.README.md: Updated documentation with examples and clarifications for the new inputs.Additional new action files added:
octopus-package-release/action.yml: New composite action for packaging releases.push-to-aws-ecr-repository/action.yml: New composite action for ECR operations.push-to-aws-ecr-repository/ecr-policy.json: IAM policy configuration for ECR access.Backward compatibility: Both new inputs to
bake-oci-manifestsare optional with sensible defaults. Existing single-service repos and current production callers continue to work unchanged.No breaking changes.