[IMPAC-654] IE: Javascript errors on widget settings and display#401
Conversation
rheasunshine
changed the title
cesar-tonnoir
left a comment
cesar-tonnoir
left a comment
There was a problem hiding this comment.
A few minor changes, other than that: looks good.
thanks for the lodash fixes
| $scope.displayAccount = -> | ||
| $scope.updateSettings(false).then -> | ||
| w.format() | ||
| $timeout -> |
There was a problem hiding this comment.
why do you need a $timeout here?
the timeout should be applied to the execution of w.format(), not to the definition of the method (alos, , 0 is optional:
$scope.displayAccount = ->
$scope.updateSettings(false).then ->
$timeout(-> w.format())| } | ||
| input[type="range"] { | ||
| height: 20px; | ||
| height: auto; |
There was a problem hiding this comment.
have you tested this does not impact the other widgets that already use a range input?
There was a problem hiding this comment.
Yes the other widgets are good to go in both IE and chrome.
| suggestedMin: 0 | ||
| suggestedMax: 100 | ||
| maxTicksLimit: 5 | ||
| suggestedMin: 0 |
There was a problem hiding this comment.
you can even refactor it to:
options = {
scales:
yAxes: [
{
ticks:
suggestedMin: 0
suggestedMax: 100
maxTicksLimit: 5
}
]
showXLabels: false
pointDot: false
currency: '%'
}| } No newline at end of file | ||
| .analytics .widget-item { | ||
| .content { | ||
| height: auto !important; |
There was a problem hiding this comment.
No, this should be fixed another way (without using !important).
Plus, be careful there: you are applying height: auto !important; to .analytics .widget-item .content => it will be applied to all the widgets, not only salaries summary...
|
@cesar-tonnoir Hey fixed all but the Range input... Should work everywhere. Need to make sure I've covered all the widgets it is used in.. otherwise other fixes are pushed |
cesar-tonnoir
changed the base branch from
release/v1.5.7
to
release/v1.6.1
| } No newline at end of file | ||
| .analytics .widget-item { | ||
| .content { | ||
| height: auto; |
There was a problem hiding this comment.
I don't think this is necessary - will remove
| .expandable-filterable-widget(); | ||
| .analytics .widget-item { | ||
| .content { | ||
| height: auto; |
| } | ||
| .chart-container { | ||
| max-height: 125px; | ||
| max-height: auto; |
2 participants
@cesar-tonnoir
-Fixed some js method errors in IE with lodash (there are inconsistencies with this throughout the project that should be fixed at some point)
-Allow settings changes in expense to turnover widget
-Fixed salaries summary and workforce summary widgets
-Made input range bars (globally) visible in IE