[IMPAC-681] Fix tags to allow special chars#466
Merged
xaun merged 1 commit intomaestrano:release/v1.6.9from Feb 5, 2018
xaun:fix/681-tags
Merged
[IMPAC-681] Fix tags to allow special chars#466xaun merged 1 commit intomaestrano:release/v1.6.9from xaun:fix/681-tags
xaun merged 1 commit intomaestrano:release/v1.6.9from
xaun:fix/681-tags
Conversation
Add ASCII encode/decoding for tag values
cesar-tonnoir
approved these changes
Feb 2, 2018
Contributor
cesar-tonnoir
left a comment
cesar-tonnoir
left a comment
There was a problem hiding this comment.
LGTM - to be tested on staging + UAT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ASCII encode/decoding for tag values.
I looked at implementing some parsing on the params level in the widgets service. But I couldn't find something that worked perfectly for both not effecting other features & parsing it to the right ASCII format where the API would work and filter the accounts. Also as the app is not specced very well, I would rather parse the tag values in the isolated component, so we don't have to do extensive testing across everything incase the blanket parsing causes some regressions on other things.