Fix Chrome not launched on TravisCi (build still broken)#470
Closed
xaun wants to merge 1 commit intomaestrano:release/v1.6.9from
xaun:fix/travis-chromelauncher
Closed
Fix Chrome not launched on TravisCi (build still broken)#470xaun wants to merge 1 commit intomaestrano:release/v1.6.9from xaun:fix/travis-chromelauncher
xaun wants to merge 1 commit intomaestrano:release/v1.6.9from
xaun:fix/travis-chromelauncher
Conversation
Contributor
Author
|
Merged into #479 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cesar-tonnoir I have tried to fix the build but cannot get it working. This at least fixes the chrome launching problems.
I think the problems now are something to do with the dependency file loading. I have tried loading the core packages in a specific order, and excluding them from the Wiredep with no success. It is really a crappy system.
Here is a glimpse of the current errors after my Chrome launcher fix:
In later attempts I manage to fix these exact problems by moving these deps (in karma.conf.js files) above the rest:
But then other dep issues arose..
I cannot find a quick fix and would need more scope to look at a smarter solution (some people talking about requireJS, but setup doesn't look easy) for it unless you know what's wrong / have an idea?
I thought open these changes rather than delete the whole branch. Thanks