[IMPAC-791] Add Generic Table Layout#501
Merged
cesar-tonnoir merged 6 commits intomaestrano:release/v1.8.0from Mar 21, 2018
xaun:feature/791-table-layout
Merged
[IMPAC-791] Add Generic Table Layout#501cesar-tonnoir merged 6 commits intomaestrano:release/v1.8.0from xaun:feature/791-table-layout
cesar-tonnoir merged 6 commits intomaestrano:release/v1.8.0from
xaun:feature/791-table-layout
Conversation
Contributor
cesar-tonnoir
left a comment
cesar-tonnoir
left a comment
There was a problem hiding this comment.
The table structure is a bit complex, but so is the requirement.
According to your doc, I think this recursive nested table model is the most flexible solution, with dynamic columns and grouped rows.
Can you please add a slight change: it would be better to have the columns of index > 0 aligned right rather than left (amounts will be easier to read)
Thanks! 🍻
Contributor
Author
|
@cesar-tonnoir done plus a fix ;)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEFORE MERGE:
@cesar-tonnoir please review last 2 commits for IMPAC-791 & here is the wiki you requested.