Skip to content

Fix pulling from a custom registry #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vweevers wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix pulling from a custom registry #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9f8ec7
Fix forwarding of version option to docker-remote-api
vweevers Jul 31, 2021
b7b315c
Fix pulling from a custom registry
vweevers Jul 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ var pull = function (image, opts, cb) {
image = parse(image)
if (!image) throw new Error('Invalid image')

var request = docker(opts.host, {version: opts.version || 'v1.15'})
var request = docker({host: opts.host, version: opts.version || 'v1.21'})
var that = new events.EventEmitter()
var layers = {}
var progress = {}
Expand Down Expand Up @@ -42,11 +42,20 @@ var pull = function (image, opts, cb) {
cb()
}

var fromImage = image.repository

if (image.namespace) {
fromImage = image.namespace + '/' + fromImage
}

if (image.registry) {
fromImage = image.registry + '/' + fromImage
}

var post = request.post('/images/create', {
qs: {
fromImage: (image.namespace ? image.namespace + '/' : '') + image.repository,
tag: image.tag || 'latest',
registry: image.registry || ''
fromImage: fromImage,
tag: image.tag || 'latest'
},
headers: {
'X-Registry-Auth': {
Expand Down