Do not generate a new ID when playing mana abilities#14822
Merged
xenohedron merged 1 commit intomagefree:masterfrom May 2, 2026
Merged
Do not generate a new ID when playing mana abilities#14822xenohedron merged 1 commit intomagefree:masterfrom
xenohedron merged 1 commit intomagefree:masterfrom
Conversation
It seems that `playManaAbility()` is called at a different time (earier) than `playAbility()` and thus its events (`MANA_ADDED` etc) get the new ID in them and not the old one, whereas this is not the case for events fired by playing non-mana abilities. Since no stack object is created for mana abilities, generating a new ID should not be necessary. Fixes: magefree@b814837eb8 See: magefree#14382 See: magefree#14381
xenohedron
approved these changes
May 2, 2026
JayDi85
reviewed
May 2, 2026
| int bookmark = game.bookmarkState(); | ||
| //20260116 - 109.4a | ||
| //The controller of a mana ability is determined as though it were on the stack. | ||
| ability.newId(); |
Member
There was a problem hiding this comment.
@xenohedron must comment newId and add docs about it like
//do not generate new id cause it can break mana events, see #14822
//ability.newId();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that
playManaAbility()is called at a different time (earier) thanplayAbility()and thus its events (MANA_ADDEDetc) get the new ID in them and not the old one, whereas this is not the case for events fired by playing non-mana abilities. Since no stack object is created for mana abilities, generating a new ID should not be necessary.Fixes: b814837eb8
See: #14382
See: #14381