Remove forbidden `@author` tag #37016

fredden · 2023-03-07T14:13:41Z

Description

According to https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space, the @author tag is not permitted in Magento. This pull request removes this tag from some modules. Given there are so many instances of this tag, I've opened a small pull request to get the process started. I expect that the linter will force me to fix several other coding standards violations on the way, so having a smaller pull request means that task is easier to manage. I plan to open more pull requests to tackle the other instances of this tag.

See also magento/magento-coding-standard#382 and magento/magento-coding-standard#167

Manual testing scenarios

There are not code changes in this pull request. This pull request only removes forbidden comments.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Remove forbidden @author tag #37266: Remove forbidden @author tag

m2-assistant · 2023-03-07T14:13:45Z

Hi @fredden. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

magento-automated-testing · 2023-03-07T14:24:46Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

leonhelmus

Looks good to me!

leonhelmus · 2023-03-20T10:51:41Z

@magento create issue

ihor-sviziev · 2023-03-22T13:29:17Z

Adding the same priority as #36976 (comment)

engcom-Lima · 2023-05-17T10:20:51Z

@magento run all tests

magento-automated-testing · 2023-05-17T10:21:01Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Lima · 2023-05-18T10:58:08Z

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

Verified @author tag got removed from sales-rule-shipping-sitemap module.

Before: ✖️

After: ✔️

No additional manual test cases is required as part of regression as this PR is related to the removal of @author tag from sales-rule-shipping-sitemap module.
Builds are failed. Hence, moving this PR to Extended Testing.

engcom-Echo · 2023-12-18T07:40:56Z

@magento run all tests

magento-automated-testing · 2023-12-18T07:41:03Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Echo · 2024-06-07T09:34:45Z

@magento run all tests

engcom-Dash · 2025-07-25T10:06:13Z

Bot moved this PR to "To Approve" Bucket. As the testing is already done & changes looks good hence moving this PR to "Extended Testing" for further analysis.

engcom-Dash · 2025-07-25T10:10:08Z

@magento run all tests

engcom-Dash · 2025-07-25T14:28:09Z

@magento run all tests

engcom-Dash · 2025-07-28T06:02:09Z

@magento run all tests

engcom-Dash · 2025-07-28T08:40:03Z

@magento run Functional Tests B2B, Integration Tests, Unit Tests, WebAPI Tests

engcom-Dash · 2025-07-28T12:43:39Z

@magento run Functional Tests B2B, Integration Tests, WebAPI Tests

engcom-Dash · 2025-07-31T09:40:19Z

@magento run all tests

engcom-Dash · 2025-07-31T13:47:41Z

@magento run all tests

engcom-Dash · 2025-08-01T05:04:58Z

@magento run all tests

engcom-Dash · 2025-08-01T08:17:16Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests

engcom-Dash · 2025-08-01T12:25:32Z

The consistent Functional B2B Tests failure in the last two consecutive builds is known issue. Other failures seems to be flaky. They neither failing because of the code changes done in this PR nor part of this PR.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37016/627fd1a7893a1c03b6fbdea7a49a50ca/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37016/c91fb71a604678208a303f0483ef71b0/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issue: AdminChangeAllCustomersGroupViaGridTest https://jira.corp.adobe.com/browse/ACQE-8335

The Functional CE Tests failure in the last two consecutive builds are inconsistent & flaky. They neither failing because of the code changes done in this PR nor part of this PR.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37016/2ca099f52c8512b75482c6dba4c67a7c/Functional/allure-report-ce/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37016/0ec545a2a537c12af00c0a0fc73b93fe/Functional/allure-report-ce/index.html#categories/bdbf199525818fae7a8651db9eafe741

The Functional EE Tests failure in the last two consecutive builds are inconsistent & flaky. They neither failing because of the code changes done in this PR nor part of this PR.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37016/61123cdb372f55760d26287b367bbc1b/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37016/f1dd21722065d94d9d0e33e111ee45c5/Functional/allure-report-ee/index.html#categories/bdbf199525818fae7a8651db9eafe741

engcom-Dash · 2025-08-01T12:31:45Z

The consistent Integration Tests failure in the last two consecutive builds are known issues and JIRA has been present for the same

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37016/ee3cc5639a59e6f7ef8cbc26a384702b/Integration/console-error-logs.html

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/37016/632ea01d8d6837f1bcdd6c7205f3b75d/Integration/console-error-logs.html

Known Issues:

Hence moving this PR in Merge In Progress

Remove forbidden @author tag

68566f7

m2-github-services added Partner: Fisheye partners-contribution Pull Request is created by Magento Partner labels Mar 7, 2023

leonhelmus approved these changes Mar 20, 2023

View reviewed changes

m2-community-project bot assigned leonhelmus Mar 20, 2023

m2-community-project bot added the Progress: ready for testing label Mar 20, 2023

m2-assistant bot mentioned this pull request Mar 20, 2023

[Issue] Remove forbidden @author tag #37266

Closed

5 tasks

ihor-sviziev added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 22, 2023

Merge branch '2.4-develop' into no-author/sales-rule-shipping-sitemap

2250c2d

engcom-Lima self-assigned this May 18, 2023

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels May 18, 2023

m2-community-project bot added Progress: extended testing and removed Progress: testing in progress labels May 18, 2023

Merge branch '2.4-develop' into no-author/sales-rule-shipping-sitemap

f44c9d9

engcom-Echo self-assigned this Jun 7, 2024

Merge branch '2.4-develop' into no-author/sales-rule-shipping-sitemap

3fddfe4

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing labels Jun 7, 2024

Fixed static test failrues

20973b5

m2-community-project bot added Progress: to approve and removed Progress: extended testing labels Jul 17, 2024

Merge branch '2.4-develop' into no-author/sales-rule-shipping-sitemap

29fe91e

engcom-Dash moved this from To Approve to Extended Testing (optional) in Pull Requests Dashboard Jul 25, 2025

ct-prd-projects-boards-automation bot added the Progress: extended testing label Jul 25, 2025

engcom-Dash removed the Progress: to approve label Jul 25, 2025

engcom-Dash self-assigned this Jul 25, 2025

Fixed Static Failures

af74e65

engcom-Dash and others added 2 commits July 28, 2025 11:24

Merge branch '2.4-develop' into no-author/sales-rule-shipping-sitemap

1c576b5

Fixed Static Failure

d1a7dae

Merge branch '2.4-develop' into no-author/sales-rule-shipping-sitemap

901b8de

Merge branch '2.4-develop' into no-author/sales-rule-shipping-sitemap

f6faf7f

Merge branch '2.4-develop' into no-author/sales-rule-shipping-sitemap

e9ec03b

engcom-Dash moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Aug 1, 2025

ct-prd-projects-boards-automation bot removed the Progress: extended testing label Aug 1, 2025

magento-devops-reposync-svc merged commit 17ad968 into magento:2.4-develop Aug 11, 2025
8 of 12 checks passed

ct-prd-projects-boards-automation bot moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Aug 11, 2025

fredden deleted the no-author/sales-rule-shipping-sitemap branch August 29, 2025 20:55

Remove forbidden @author tag #37016

Remove forbidden @author tag #37016

Uh oh!

Conversation

fredden commented Mar 7, 2023 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Manual testing scenarios

Contribution checklist

Resolved issues:

Uh oh!

m2-assistant bot commented Mar 7, 2023

Uh oh!

magento-automated-testing bot commented Mar 7, 2023

Uh oh!

leonhelmus left a comment

Choose a reason for hiding this comment

Uh oh!

leonhelmus commented Mar 20, 2023

Uh oh!

ihor-sviziev commented Mar 22, 2023

Uh oh!

engcom-Lima commented May 17, 2023

Uh oh!

magento-automated-testing bot commented May 17, 2023

Uh oh!

engcom-Lima commented May 18, 2023

Uh oh!

engcom-Echo commented Dec 18, 2023

Uh oh!

magento-automated-testing bot commented Dec 18, 2023

Uh oh!

engcom-Echo commented Jun 7, 2024

Uh oh!

engcom-Dash commented Jul 25, 2025

Uh oh!

engcom-Dash commented Jul 25, 2025

Uh oh!

engcom-Dash commented Jul 25, 2025

Uh oh!

engcom-Dash commented Jul 28, 2025

Uh oh!

engcom-Dash commented Jul 28, 2025

Uh oh!

engcom-Dash commented Jul 28, 2025

Uh oh!

engcom-Dash commented Jul 31, 2025

Uh oh!

engcom-Dash commented Jul 31, 2025

Uh oh!

engcom-Dash commented Aug 1, 2025

Uh oh!

engcom-Dash commented Aug 1, 2025

Uh oh!

engcom-Dash commented Aug 1, 2025

Uh oh!

engcom-Dash commented Aug 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Remove forbidden `@author` tag #37016

Remove forbidden `@author` tag #37016

fredden commented Mar 7, 2023 •

edited by m2-assistant bot

Loading