Skip to content

Centralized logging - add multiline indent, remove syslog output by default#17

Merged
binary1230 merged 2 commits intomasterfrom
centralized_logging
Jul 12, 2016
Merged

Centralized logging - add multiline indent, remove syslog output by default#17
binary1230 merged 2 commits intomasterfrom
centralized_logging

Conversation

@binary1230
Copy link
Copy Markdown
Contributor

2 things:

  1. Add a formatter (which is off by default but can be switched on via INI) that takes any multiline output and indents it. This makes it easier for external log tools to parse our output and keep stack traces (which output multiple lines) together as one logical unit.
  2. By default we output to syslog via development-defaults.ini and downstream configuration can't switch this off. Make it so we don't output to syslog by default so that puppet and other things can change this behavior later

- this was causing output to syslog no matter what development.ini said
- this is not enabled by default and has to be turned on in the INI
- this enables external apps to easily parse multiline logfile output as one continuous entry
- each line of the log will be indented
@binary1230
Copy link
Copy Markdown
Contributor Author

IMPORTANT NOTE: we used to output to syslog by default mostly because it's 1) convenient and 2) if we start filling up the logs with error message spam, syslog will rotate them for us which usually decreases the filesize dramatically when they are compressed.

so it's important for anyone not deploying through our puppet stuff (like Anthrocon) to be aware of this. though, the real answer is ... don't fill up the logs with gigabytes of errors and run out of disk space :)

@kitsuta
Copy link
Copy Markdown
Member

kitsuta commented Jul 12, 2016

+1

@binary1230 binary1230 merged commit 0afe30c into master Jul 12, 2016
@binary1230 binary1230 deleted the centralized_logging branch July 12, 2016 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants