turn up all logging thresholds to the highest levels#18
Merged
binary1230 merged 1 commit intomasterfrom Aug 14, 2016
Merged
Conversation
- doesn't add much spam but does report which files are actually being served up, which is good data to collect
Contributor
|
Seems fine. Even if this got merged into the main repo where I work, we have puppet setting these config options anyway, so making debug the default seems okay. You can now remove these two lines since they're no longer necessary: Though if you want to merge this in without bothering, that would be okay too since they're merely redundant and not hurting anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
definitely want this on our servers in order to get the access logs, but also, I think it's a sensible default even if it adds a line for each access.