Skip to content

Add debugging support#6

Merged
binary1230 merged 2 commits intomasterfrom
fix_debugging_support
Nov 28, 2014
Merged

Add debugging support#6
binary1230 merged 2 commits intomasterfrom
fix_debugging_support

Conversation

@binary1230
Copy link
Copy Markdown
Contributor

Moved these files from the ubersystem project into the sideboard project where they now belong

you can use these with PyCharm in order to do debugging

these do not affect normal operations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just to be clear, sideboard/run_server.py is already only there for debug purposes. (This is not obvious because we're not using any actual packaging, but in production the expectation is that we'd use cherryd to spin up the server.)

Even accounting for the fact that MAGFest probably uses sideboard/run_server.py in production, is there any reason not to always lockfiles on startup? If we ever have a case where Sideboard shuts down and leaves lockfiles there, I don't think we'd ever want them to stick around. So really we should just add this function to run_server.py and call it there (although it might be worth checking to see that Sideboard isn't already running before we remove the lockfiles).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i actually was having supervisord use run_server.py for production, so i guess that's why I didn't want to touch it there.

it's probably a good call to make sure the lockfiles are cleared out each server run, debug or not, sure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I figured we were doing that, which is fine. The public Sideboard repo doesn't have any packaging, because my old job decided to stop pushing changes and then took down the repo, so that means that we don't have a "real" init.d script for doing start/stop/restart with a pidfile and all that jazz. Which is fine, since our supervisord is doing a fine job of making sure that the service is running, though in the long run (meaning next year) it'll be great if we can do things with real packaging (like we'll be installing .deb packages and using real init.d scripts and whatnot).

binary1230 added a commit that referenced this pull request Nov 28, 2014
@binary1230 binary1230 merged commit 66ba2ac into master Nov 28, 2014
@binary1230 binary1230 deleted the fix_debugging_support branch November 28, 2014 15:38
RobRuana pushed a commit that referenced this pull request Dec 6, 2017
Update versions of Python and Node, fix Dockerfile build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants