Conversation
Upstream needs to sync up with MAGFest's sideboard. Even if this isn't merged, we need it to create a mergeable PR.
Contributor
|
I am cool with this. @EliAndrewC looks good? |
Contributor
|
LGTM although I don't speak Docker. Still, people who don't care about Docker can just ignore this file, so it's not going to hurt anything to include it in the repo. |
RobRuana
approved these changes
May 4, 2017
Contributor
RobRuana
left a comment
RobRuana
left a comment
There was a problem hiding this comment.
+1!
Unrelated, but the build failures are still coming from the multithreaded pub-sub stuff. Probably pretty important if you're using that in your other projects.
Contributor
|
+1
On May 4, 2017 10:09 AM, "Victoria Earl" <notifications@github.com> wrote:
Merged #79 <#79>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#79 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFKYyFoLtmctYJSxIFcxTnUmz56JM1VQks5r2dwMgaJpZM4NQTWx>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream needs to sync up with MAGFest's sideboard. Even if this isn't merged, we need it to create a mergeable PR.