use pip to install requirements by default#9
Conversation
- make new function match the name of the old function - reposition to make the diff look nicer
|
and to be clear, this is currently in use by production deploys for magclassic |
There was a problem hiding this comment.
This line will break in Python 2.7 because it explicitly refers to pip3. I know that MAGFest doesn't care about older versions of Python, but most of the Sideboard projects where I work are still on 2.7, and Sideboard is explicitly a single-source project which works on either Python 2.7 or 3.x, so I'd like to keep it that way if possible.
I have at least 3 meetings this morning, but after those are done I can try checking out this branch on my dev box and see what we could put here that would work on both Python versions.
There was a problem hiding this comment.
ok copy that. i can try and figure out if there's a pip command that runs the right version, 2 or 3, depending on how the venv was installed. or maybe we can query the environment for that
There was a problem hiding this comment.
@EliAndrewC I changed this path from 'pip3' to 'pip', so should be solid for python2
There was a problem hiding this comment.
Looks good, that ought to work, so I'll just go ahead and merge and if there are some unexpected Python2 issues I can fix those later.
use pip to install requirements by default
Pull in updates from Magfest's Sideboard
2 participants
install_deps() now uses pip to install stuff, instead of setuptools
needed for docker
removes an extra step when using puppet
@EliAndrewC need your eyes on this for merge. afterwards I have a bunch of other PR's that change the sideboard branch back to master
This PR should be merged --first--